[Feature] Add v4 backward compatibility #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Key changes include:
|
|
Hi @orkun1675, I wanted to get your thoughts on the code, as you wrote most of the code I modified, and you have more expertise with native iOS and Android code than I do. If it looks good to you, I'll go ahead and merge it so we can release version Thanks! |
orkun1675
reviewed
Dec 18, 2024
orkun1675
reviewed
Dec 20, 2024
|
PR added to version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure seamless transition for users upgrading from v4 to v5, the AlarmSettings class has been modified to include backward compatibility. This update addresses potential issues when retrieving alarms created in v4, ensuring that all settings, including dateTime and volumeSettings, are correctly interpreted and converted in v5.